refactor(gossipsub): in-place negative-score peer removal #6209
+21
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onur-ozkan
changed the title
onur-ozkan
force-pushed
the
opt-peer-removal-iter
branch
from
ceec87e to
797293e
Compare
Contributor
|
This pull request has merge conflicts. Could you please resolve them @onur-ozkan? 🙏 |
jxs
reviewed
Nov 19, 2025
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Hi, and thanks for looking into it! Since extract_if has been stabilized I think we can use it to make it easier to count the removed peers wdyt?
Contributor
Author
We would need to raise MSRV to very recent version. I am fine with that but I think there will be many downstream users not liking this. |
This change improves peer removal during `heartbeat` by switching from a two-pass remove logic to an in-place `retain` with very small size intermediate variable `removed_peers_count`. Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
onur-ozkan
force-pushed
the
opt-peer-removal-iter
branch
from
797293e to
44cb2c5
Compare
jxs
approved these changes
Dec 5, 2025
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Hi, and thanks for looking into it! Since
extract_ifhas been stabilized I think we can use it to make it easier to count the removed peers wdyt?We would need to raise MSRV to very recent version. I am fine with that but I think there will be many downstream users not liking this.
sorry for the delay.
Ah right it was only stabilized in October, ok let's leave a TODO then for when MSRV is updated to support it.
Thanks!
Contributor
Author
Done :) |
Member
|
ah, fmt job seems to be failing |
Signed-off-by: Onur Özkan <[email protected]>
onur-ozkan
force-pushed
the
opt-peer-removal-iter
branch
from
37f29a3 to
adce9f3
Compare
mergify
bot
dismissed
elenaf9’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
Contributor
Merge Queue Status✅ The pull request has been merged This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change improves peer removal during
heartbeatby switching from a two-pass remove logic to an in-placeretainwith very small size intermediate variableremoved_peers_count.Change checklist